move deployment configuration/writeup to synse server repo. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KylerBurke
suggested changes
Apr 6, 2018
There was a problem hiding this comment.
Errors from make unix and make tcp
Status: Downloaded newer image for vaporio/synse-server:2.0.0
Pulling emulator-plugin (vaporio/emulator-plugin:latest)...
ERROR: The image for the service you're trying to recreate has been removed. If you continue, volume data could be lost. Consider backing up your data before continuing.
Continue with the new image? [yN]y
Pulling emulator-plugin (vaporio/emulator-plugin:latest)...
ERROR: pull access denied for vaporio/emulator-plugin, repository does not exist or may require 'docker login'
|
@Kontazler ooohhhh, good catch. just made https://hub.docker.com/r/vaporio/emulator-plugin/ public, so this should work if you try again. |
MatthewHink
approved these changes
Apr 6, 2018
KylerBurke
approved these changes
Apr 6, 2018
|
Image pulling successfully now, thanks. Test and Scan routes behaving as expected :) |
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 88.98% 88.98%
=======================================
Files 40 40
Lines 1080 1080
=======================================
Hits 961 961
Misses 119 119Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #121
This PR moves the deployment configs from the emulator plugin to this repo, where they make more sense to exist, since they do describe a Synse Server deployment..