Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dockerfile to download emulator from github release #129

Merged
merged 2 commits into from
Apr 16, 2018

Conversation

edaniszewski
Copy link
Contributor

fixes #124

No rush on this, as its mostly optimizations/improvements to the deployment/release flow for the emulator (which doesn't change frequently ATM).

This PR does a few things:

  • Downloads the built-in emulator plugin (for non-slim images) directly from github releases (gets it from the latest release)
  • Removes the emulator binary that lived in this repo and was being added in (no longer needed as per the above)
  • Make a slim dockerfile. Before we did this by some no-so-fancy moving around of .dockerignore files. This was both non-intuitive, and with the new changes no longer needed to happen. Now release.dockerfile corresponds to synse-server with emulator, slim.dockerfile corresponds to synse-server without emulator.
  • update to build dependency to reduce image size by a decent amount. we kept gcc installed because the gRPC stuff used it. turns out, that it only used some of the dependencies for the gcc install, libstdc++. Now we just keep libstdc++ on the image, which results in ~80Mb saved.
  • add some things to dockerignore to further reduce build context/size (small, but it all adds up)
  • updated Makefile appropriately

Copy link
Contributor

@MatthewHink MatthewHink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I though I +1ed this earlier but must have gotten distracted.

@edaniszewski
Copy link
Contributor Author

thanks -- no worries. I'm going to hold off on merging this until next week for stability. this really shouldn't break anything, but I'd rather not introduce a change into master unless its necessary at this point.

@codecov-io
Copy link

codecov-io commented Apr 16, 2018

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files          40       40           
  Lines        1097     1097           
=======================================
  Hits          970      970           
  Misses        127      127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdc2aa...465d254. Read the comment docs.

@edaniszewski edaniszewski merged commit 38b6c0a into master Apr 16, 2018
@edaniszewski edaniszewski deleted the emulator-from-remote branch April 16, 2018 13:10
edaniszewski pushed a commit to edaniszewski/synse-server that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get emulator binary as part of image build
3 participants