update dockerfile to download emulator from github release #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #124
No rush on this, as its mostly optimizations/improvements to the deployment/release flow for the emulator (which doesn't change frequently ATM).
This PR does a few things:
slim
dockerfile. Before we did this by some no-so-fancy moving around of .dockerignore files. This was both non-intuitive, and with the new changes no longer needed to happen. Nowrelease.dockerfile
corresponds to synse-server with emulator,slim.dockerfile
corresponds to synse-server without emulator.gcc
installed because the gRPC stuff used it. turns out, that it only used some of the dependencies for the gcc install,libstdc++
. Now we just keep libstdc++ on the image, which results in ~80Mb saved.