Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get API docs hosted via GitHub pages #132

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Conversation

edaniszewski
Copy link
Contributor

this should fix #128

The thing that made this a bit of a headache is that GitHub pages and ReadTheDocs both operate out of the docs/ directory, so before I had them stomping on one another, and it didn't seem like there was a good way to configure where they should look.

This PR mostly just moves around existing things. The build output for the API docs now lives directly in the docs/ directory. It makes it a bit messy and sorta hides the RTD source (source dir), but this should work. I tested out this kind of setup on a simplified test repo of my own and it appeared to work out okay.

The changes for this won't show up on RTD or GitHub Pages until pushed to master, since the builds for those are only configured on push to master. Once this is merged into master, will need to play around with the repo settings a little to get it working, I think. Will also need to verify that RTD still builds correctly. Finally, once everything is verified okay, I'll update the RTD docs to point to the correct place for the API documentation.

Copy link
Contributor

@MatthewHink MatthewHink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@edaniszewski edaniszewski merged commit cd664a5 into master Apr 12, 2018
@edaniszewski edaniszewski deleted the hosted-api-docs branch April 12, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get API docs hosted
2 participants