Test updates #143
Merged
Test updates #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 88.77% 88.77%
=======================================
Files 40 40
Lines 1114 1114
=======================================
Hits 989 989
Misses 125 125Continue to review full report at Codecov.
|
MatthewHink
approved these changes
Apr 17, 2018
| @@ -1 +1 @@ | |||
| recursive-include synse/locale *.mo | |||
| recursive-include synse/i18n *.mo | |||
There was a problem hiding this comment.
i18n means localization, correct?
There was a problem hiding this comment.
i think it technically means internationalization, but i've seen it used to mean localization. not sure why its named that, but is what it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #141
this PR does a little bit of cleanup/test updates and does an overhaul of the end-to-end tests. the end-to-end overhaul includes: restructuring, cleanup, test additions, documenting, generalizing.
as always, more tests could probably be added, but this is a pretty solid base.
will squash on merge.