Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add labels do dockerfiles, consolidate some layers #145

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

edaniszewski
Copy link
Contributor

This adds labels to the Synse Server dockerfiles to provide some image/container metadata, such as the image build date, git commit, git repo, synse version, etc. This should be helpful if there are issues when someone is using "latest" and we need to know the exact build version, e.g.

This also does a little bit of cleanup and layer consolidation as per the dockerfile "best practices"

@codecov-io
Copy link

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files          40       40           
  Lines        1114     1114           
=======================================
  Hits          989      989           
  Misses        125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c724d0e...63382e1. Read the comment docs.

@edaniszewski edaniszewski merged commit a998ba0 into master Apr 23, 2018
@edaniszewski edaniszewski deleted the dockerfile-labels branch April 23, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants