Add example deployment for k8s, update docs #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 41 41
Lines 1111 1111
=======================================
Hits 998 998
Misses 113 113Continue to review full report at Codecov.
|
timfallmk
approved these changes
May 18, 2018
deploy/k8s/README.md
Outdated
| Emulator Plugin for [Kubernetes][kubernetes]. | ||
|
|
||
| ## Deployments | ||
| As a general note - the Emulator Plugin does not need to be containerized. In |
There was a problem hiding this comment.
I would say "containerized separately" since everything in k8s needs to be in a container.
| - a basic understanding of Kubernetes | ||
| - an operational Kubernetes cluster | ||
| - access to the Kubernetes cluster | ||
| - [`kubectl`][kubectl], configured to talk to your cluster |
There was a problem hiding this comment.
Should we mention the cli?
|
thanks! added in your suggestions. |
edaniszewski
added a commit
to edaniszewski/synse-server
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@timfallmk -- could you glance through this to make sure it all sounds sane for a simple example?
fixes #161