Fix bug in Docker image build flow allowing for out-of-date base image #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 41 41
Lines 1111 1111
=======================================
Hits 998 998
Misses 113 113
Continue to review full report at Codecov.
|
edaniszewski
pushed a commit
to edaniszewski/synse-server
that referenced
this pull request
Dec 9, 2021
Backout Makefile changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
release.dockerfileimage was based onvaporio/synse-server:slim. Theslimtag wasn't managed great in the build flow, and it also exists in DockerHub, so if it didn't get built locally with the latest version, it would reach out to DockerHub and pull the stale version.This PR changes the base image tag to one that is explicitly not in DockerHub and adds in some checking/handling around it.
The micro version is also bumped so we can create a new release and get correctly versioned images into DockerHub.