Fix build args for old docker versions #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## sdk1.0 #183 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 44 44
Lines 1276 1276
=======================================
Hits 1039 1039
Misses 237 237Continue to review full report at Codecov.
|
…nto docker-args
edaniszewski
added a commit
that referenced
this pull request
Jul 2, 2018
* start to update internal grpc client for sdk1.0 changes * update internal grpc client handling * add capabilities route * update models, update tests * update plugins route to include metadata and health info * update plugin registration flow. still needs to be cleaned up, tests need to be updated/added * add support for service discovery via kubernetes service endpointswith labels * update deployment configurations, fix bug in unix registration * update tests for plugin flow changes * update api docs * use new synse_grpc package * more doc updates, fix serialization bug * user guide docs update * update user guide docs * fix bug where no returned reading would cause failure (#178) * Change read scheme to allow multiple readings of the same type (#181) * update read scheme to allow multiple readings of the same type from the same device (e.g. a single device might provide multiple voltage readings) * update api docs * Fix build args for old docker versions (#183) * fix build args for old docker version * update comment * scan output should have type, not kind (#186) * final updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the conversation at #182 with @edaniszewski, it seems like old docker versions don't allow build args to be passed in if they aren't consumed. This PR follows the suggestion to include the image metadata setting (that we have in the
dockerfile/slim.dockerfile) indockerfile/release.dockerfileto make a successfully build.