Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning #189

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Versioning #189

merged 2 commits into from
Jul 3, 2018

Conversation

edaniszewski
Copy link
Contributor

#184

This PR changes the URL version from .../synse/MAJ.MIN/... to .../synse/v2/... -- see the issue for more details.

Things creating the URL dynamically should not be affected. Things that have a hardcoded version in the URI will break. They should be updated to get the version dynamically.

@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files          44       44           
  Lines        1282     1282           
=======================================
  Hits         1042     1042           
  Misses        240      240
Impacted Files Coverage Δ
synse/scheme/version.py 100% <ø> (ø) ⬆️
synse/version.py 83.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf90b6...6e8035b. Read the comment docs.

@edaniszewski edaniszewski merged commit 9afd410 into master Jul 3, 2018
@edaniszewski edaniszewski deleted the versioning branch July 3, 2018 21:29
edaniszewski added a commit to edaniszewski/synse-server that referenced this pull request Dec 9, 2021
update default i2c emulator config to provide correct reading values …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants