simplify docker build and container init #207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on #206 and ran into a few things which ultimately lead me to learn that with docker multistage builds, you could reference previous stages for a new stage, and that a simple init system for the container (e.g. tini) would be easier than updating the synse bash script entrypoint to work correctly.
This PR uses the simple init system (making #206 obsolete and fixing #205) and vastly simplifies the build process for the synse-server images.