Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading plugin cached readings #213

Merged
merged 9 commits into from
Oct 23, 2018
Merged

Conversation

edaniszewski
Copy link
Contributor

Currently a WIP until all the other dependent work is done.

a new version of synse-grpc will need to be released first, then the tarball here can be cleaned out, along with a few other temporary things.

Will also want to bump the minor version here

#212

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #213 into master will increase coverage by 0.51%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   82.76%   83.28%   +0.51%     
==========================================
  Files          44       46       +2     
  Lines        1300     1358      +58     
==========================================
+ Hits         1076     1131      +55     
- Misses        224      227       +3
Impacted Files Coverage Δ
synse/scheme/read.py 100% <ø> (ø) ⬆️
synse/proto/client.py 100% <100%> (ø) ⬆️
synse/__init__.py 100% <100%> (ø) ⬆️
synse/scheme/__init__.py 100% <100%> (ø) ⬆️
synse/commands/__init__.py 100% <100%> (ø) ⬆️
synse/commands/read_cached.py 100% <100%> (ø)
synse/errors.py 100% <100%> (+1.19%) ⬆️
synse/routes/core.py 91.54% <75%> (-2.11%) ⬇️
synse/scheme/read_cached.py 85.71% <85.71%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3621e5...bef6b07. Read the comment docs.

@edaniszewski edaniszewski merged commit 955f789 into master Oct 23, 2018
@edaniszewski edaniszewski deleted the read-cache branch October 23, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant