Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix k8s plugin discovery to allow multiple addrs on an endpoint #217

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

edaniszewski
Copy link
Contributor

this also adds tests and bumps the version

fixes #216

@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #217 into master will increase coverage by 4.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   83.28%   87.55%   +4.27%     
==========================================
  Files          46       46              
  Lines        1358     1358              
==========================================
+ Hits         1131     1189      +58     
+ Misses        227      169      -58
Impacted Files Coverage Δ
synse/__init__.py 100% <100%> (ø) ⬆️
synse/discovery/kubernetes.py 100% <100%> (+83.33%) ⬆️
synse/plugin.py 87.91% <0%> (+2.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955f789...0b29bbd. Read the comment docs.

@edaniszewski edaniszewski merged commit 6650dbc into master Oct 24, 2018
@edaniszewski edaniszewski deleted the k8s-discovery-bugfix branch October 24, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin discovery on k8s endpoints only registers the first endpoint subset
1 participant