scope kubernetes discovery to a single namespace #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 87.55% 87.52% -0.03%
==========================================
Files 46 46
Lines 1358 1363 +5
==========================================
+ Hits 1189 1193 +4
- Misses 169 170 +1
Continue to review full report at Codecov.
|
marcoceppi
reviewed
Oct 26, 2018
synse/discovery/kubernetes.py
Outdated
| # If no namespace is provided via user configuration, if will default to | ||
| # the 'default' namespace. | ||
| ns = config.options.get('plugin.discover.kubernetes.namespace') | ||
| if not ns: |
There was a problem hiding this comment.
This could be moved to the previous line as Dict.get supports default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #222
This also adds in a basic test case for the config to make sure that no kubernetes config values get set by default. We only want discovery to happen if its set explicitly.
tested this on a gke cluster w/ synse-server and emulator plugin.