patch: update requests dep for CVE-2018-18074 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoceppi
approved these changes
Oct 30, 2018
| @@ -24,7 +24,7 @@ pyasn1==0.4.3 # via pyasn1-modules, rsa | |||
| python-dateutil==2.7.3 # via kubernetes | |||
| pyyaml==3.12 | |||
| requests-oauthlib==1.0.0 # via kubernetes | |||
| requests==2.19.1 # via kubernetes, requests-oauthlib | |||
There was a problem hiding this comment.
nit: the # via ... is still valid. Neither kubernetes nor requests-oauthlib pins an explicit version of the library
There was a problem hiding this comment.
yeah, the requirements.txt is autogenerated via pip-compile, so if it sees the dep defined in setup.py, it assumes its a project dependency and doesn't add on the # via ... comment. I could add it back in, but it would just get removed whenever requirements.txt is regenerated.
I'll make a note of this directly in setup.py.
|
We shouldn't need to change anything except run freeze again. That would lock requests at 2.20.0 and rebuild docker images |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of
requeststo 2.20.0 to patch the CVE-2018-18074 vulnerability found inrequests<=2.19.1.Bumps the version to 2.2.4 for patch release.