Implement lock route alias #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 87.58% 87.76% +0.18%
==========================================
Files 46 46
Lines 1369 1381 +12
==========================================
+ Hits 1199 1212 +13
+ Misses 170 169 -1
Continue to review full report at Codecov.
|
edaniszewski
approved these changes
Nov 27, 2018
synse/routes/aliases.py
Outdated
|
|
||
| # Otherwise, we just read from the device. | ||
| else: | ||
| logger.debug(_('Alias alias route: reading')) |
There was a problem hiding this comment.
I think this is supposed to be 'Lock alias route'
added 2 commits
November 27, 2018 12:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #200.