Update Dockerfile to use vapor base images #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 46 46
Lines 1381 1381
=======================================
Hits 1213 1213
Misses 168 168Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 46 46
Lines 1381 1381
=======================================
Hits 1213 1213
Misses 168 168Continue to review full report at Codecov.
|
marcoceppi
approved these changes
Dec 5, 2018
| RUN apt-get update && apt-get install --no-install-recommends -y wget \ | ||
| && wget https://github.com/krallin/tini/releases/download/v0.18.0/tini_0.18.0-amd64.deb \ | ||
| && dpkg -i tini_*.deb \ | ||
| && rm tini_*.deb \ |
There was a problem hiding this comment.
It looks like tini was added to 18.10 and beyond. So we should be able to get it available through apt eventually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.