add background task to periodically invalidate device cache #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 87.83% 87.75% -0.09%
==========================================
Files 46 46
Lines 1381 1388 +7
==========================================
+ Hits 1213 1218 +5
- Misses 168 170 +2
Continue to review full report at Codecov.
|
marcoceppi
suggested changes
Feb 1, 2019
synse/factory.py
Outdated
| while True: | ||
| await asyncio.sleep(5 * 60) # 5 minutes | ||
| logger.info('task [periodic cache invalidation]: clearing device caches') | ||
| await clear_all_meta_caches() |
There was a problem hiding this comment.
If this method raises an exception the background job will terminate. I'd be good to capture, filter, and bubble/log appropriately
KylerBurke
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.