add wrapper around application constructor #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v3/staging #266 +/- ##
=============================================
Coverage ? 84.58%
=============================================
Files ? 47
Lines ? 1401
Branches ? 0
=============================================
Hits ? 1185
Misses ? 216
Partials ? 0
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## v3/staging #266 +/- ##
=============================================
Coverage ? 84.58%
=============================================
Files ? 47
Lines ? 1401
Branches ? 0
=============================================
Hits ? 1185
Misses ? 216
Partials ? 0
Continue to review full report at Codecov.
|
edaniszewski
added a commit
that referenced
this pull request
Mar 27, 2020
edaniszewski
added a commit
that referenced
this pull request
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#250
This does a little bit of reorganization and cleanup and also starts to add a wrapper
Synseclass around the Sanic application to make some of the application setup and init work cleaner. Future work will expand upon this, this PR just moves things around without changing all that much.