streamline docker build flow and image caching #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniszewski
added a commit
that referenced
this pull request
Mar 27, 2020
* checkpoint * updates * fix temporary dep issue, improve dockerfile caching
edaniszewski
added a commit
that referenced
this pull request
Mar 30, 2020
* checkpoint * updates * fix temporary dep issue, improve dockerfile caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#260
this PR removes/starts to remove a bunch of the stuff that has built up around the docker build flow for synse-server. notably, the emulator plugin install stage is now cached by virtue of pinning it to a particular version.
This also fixes a bug that was hidden in image builds before where the packages installed via the frozen requirements.txt were being overridden with latest versions of things when synse-server was installed. Now, we are sure to use the dependency versions that are pinned in requirements.txt
Temporarily, the protobuf dependency was added; this will become a dependency of synse_grpc for the newest release so it can be removed once we update synse_grpc, but until then we need to specify it here.