Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 proposal ammendment: device fqdn and aliases #276

Merged
merged 1 commit into from
Mar 8, 2019
Merged

v3 proposal ammendment: device fqdn and aliases #276

merged 1 commit into from
Mar 8, 2019

Conversation

edaniszewski
Copy link
Contributor

Adds amendment for adding configurable aliases for devices to give them a human-readable reference.

@codecov
Copy link

codecov bot commented Feb 11, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v3/staging@70b884b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             v3/staging     #276   +/-   ##
=============================================
  Coverage              ?   86.44%           
=============================================
  Files                 ?       58           
  Lines                 ?     1151           
  Branches              ?        0           
=============================================
  Hits                  ?      995           
  Misses                ?      156           
  Partials              ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b884b...a9312c1. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (v3/staging@70b884b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             v3/staging     #276   +/-   ##
=============================================
  Coverage              ?   86.44%           
=============================================
  Files                 ?       58           
  Lines                 ?     1151           
  Branches              ?        0           
=============================================
  Hits                  ?      995           
  Misses                ?      156           
  Partials              ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b884b...a9312c1. Read the comment docs.

@edaniszewski edaniszewski changed the title add ammendment-1 (device fqdn and aliases) to v3 proposals v3 proposal ammendment: device fqdn and aliases Feb 14, 2019
@edaniszewski edaniszewski changed the base branch from v3/staging to master February 14, 2019 13:15
@edaniszewski edaniszewski changed the base branch from master to v3/staging February 14, 2019 13:15
hoanhan101
hoanhan101 approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@hoanhan101 hoanhan101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edaniszewski edaniszewski merged commit 821ec66 into v3/staging Mar 8, 2019
@edaniszewski edaniszewski deleted the proposals/v3-ammend-2 branch March 8, 2019 13:13
edaniszewski added a commit that referenced this pull request Mar 27, 2020
@edaniszewski
add ammendment-1 (device fqdn and aliases) to v3 proposals (#276)
31bd603
edaniszewski added a commit that referenced this pull request Mar 30, 2020
@edaniszewski
add ammendment-1 (device fqdn and aliases) to v3 proposals (#276)
7073ddd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoanhan101 hoanhan101 hoanhan101 approved these changes

@MatthewHink MatthewHink Awaiting requested review from MatthewHink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edaniszewski @hoanhan101