Fix proposal's websocket specs #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 5, 2019 10:29
edaniszewski
approved these changes
Mar 7, 2019
| | [request/read_cache](#read-cache) | [response/reading](#reading) | | ||
| | [request/write_async](#write-asynchronous) | [response/write_async](#write-asynchronous-1) | | ||
| | [request/write_sync](#write-synchronous) | [response/write_sync](#write-synchronous-1) | | ||
| | [request/transaction](#transaction) | [response/transaction](#transaction-1) | |
There was a problem hiding this comment.
I was JUST thinking how it would be useful to have a TOC (:
| | :---- | :--- | :------- | :---------- | | ||
| | *start* | `string` | no | An RFC3339 formatted timestamp which specifies a starting bound on the cache data to return. | | ||
| | *end* | `string` | no | An RFC3339 formatted timestamp which specifies an ending bound on the cache data to return. | | ||
|
|
There was a problem hiding this comment.
whoops. this is a big omission on my part. good catch.
edaniszewski
pushed a commit
that referenced
this pull request
Mar 27, 2020
* Fix returned data scheme in response/device_summary * Fix returned data scheme in response/read * Add toc for websocket events * Fix table styling 1 * Fill in readcache event data * Add version event * Add note for plugin event * Add read device event * Update write sync event * Add write async event * Update transaction event
edaniszewski
pushed a commit
that referenced
this pull request
Mar 30, 2020
* Fix returned data scheme in response/device_summary * Fix returned data scheme in response/read * Add toc for websocket events * Fix table styling 1 * Fill in readcache event data * Add version event * Add note for plugin event * Add read device event * Update write sync event * Add write async event * Update transaction event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix websocket specs that fall out of this PR discussion.