Add some more minor fix to the proposal's websocket specs #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniszewski
approved these changes
Mar 11, 2019
| "transaction": "56a32eba-1aa6-4868-84ee-fe01af8b2e6d" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
+1 -- this is cleaner and better reflects how the HTTP API operates.
my only suggestion would be to rename the inner data to something else (maybe payload?) just so we don't have something like response['data']['data'] which is fine, but not necessarily clear if someone is reading through the code
There was a problem hiding this comment.
Oh yeah totally. I think payload is a good one.
edaniszewski
pushed a commit
that referenced
this pull request
Mar 27, 2020
* Add som to read device event * Fix write data scheme * Update response scheme for consistency * Rename request post data
edaniszewski
pushed a commit
that referenced
this pull request
Mar 30, 2020
* Add som to read device event * Fix write data scheme * Update response scheme for consistency * Rename request post data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix some minor issues with read and write data event and update the response scheme for consistency.