Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update internal modeling for plugins #287

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Conversation

edaniszewski
Copy link
Contributor

@edaniszewski edaniszewski commented Apr 5, 2019

This PR just updates the plugin modeling to something more sensible for Synse v3. It strips away some of the complexities of the v2 implementation. Particularly, it:

  • attaches all functionality to the plugin manager
  • simplifies the relationship between manager and plugin. plugins no longer self-register on init, the manager is not class member to the plugin.
  • removes the validation checks for unix plugins -- since the client will need to be initialized and used for the plugin to be initialized, a failure in the config will result in a failure to initialize
  • removes loading plugins from the default socket location. this was only complicating the code in a number of ways (plugin loading, validation, config sync) for a feature that we have not used at all.

It does not update any documentation or usage, so things will break with this PR, but upcoming PRs will drastically change components that use this, so there is no point in updating those just to change them again shortly.

Related:

@edaniszewski edaniszewski merged commit a2bddca into v3/staging Apr 5, 2019
@edaniszewski edaniszewski deleted the v3/plugin-modeling branch April 9, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant