v3 HTTP API initial implementation #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniszewski
added a commit
that referenced
this pull request
Mar 27, 2020
* initial updates for the v3 http api * move functions around * add http endpoint logging * remove old files * remove old files * more cleanup, remove dead code * start adding in support for plugin endpoints * add tags command * query param parsing, add scan support * update documentation for query params * add debug logging to commands * fix bool flag query param for tags request * add support for info command * device read/write support * add support for transaction commands * add initial support for reads * initial support for writes * cleanup * update error handling * bug fixes, cleanup, logging * bug fixes, api consistency, notes for additional fixes * updates, fixes
edaniszewski
added a commit
that referenced
this pull request
Mar 30, 2020
* initial updates for the v3 http api * move functions around * add http endpoint logging * remove old files * remove old files * more cleanup, remove dead code * start adding in support for plugin endpoints * add tags command * query param parsing, add scan support * update documentation for query params * add debug logging to commands * fix bool flag query param for tags request * add support for info command * device read/write support * add support for transaction commands * add initial support for reads * initial support for writes * cleanup * update error handling * bug fixes, cleanup, logging * bug fixes, api consistency, notes for additional fixes * updates, fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets in a basic implementation for the v3 HTTP API. It does a lot of the data modeling and hooks it into the HTTP API, while also cleaning out the old v2 HTTP API and related dead code.
This is a big PR that does many things, so its a bit to slog through. It is a work in progress in that there are still many "bugs" in the sense that it does not yet fully conform to the v3 spec. It does get a bunch of the basics for data handling in place and does some basic data formatting, but there will need to be more of that in subsequent PRs.
Related: