update tag query behavior to allow for multiple tag groups #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoanhan101
approved these changes
Aug 9, 2019
edaniszewski
added a commit
that referenced
this pull request
Mar 27, 2020
edaniszewski
added a commit
that referenced
this pull request
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #329
Previously, endpoints which take tags as params could take them as a comma separated list, or in multiple
tagsparams. For example, all of the below would be equivalent:?tags=foo,bar,baz?tags=foo&tags=bar,baz?tags=foo,bar&tags=baz?tags=foo&tags=bar&tags=bazAll the tags would be collected into a single tag group which would be used to filter the devices. If you wanted to get all fan and led devices, e.g., this would need to be done in two requests
?tags=system/type:fan?tags=system/type:ledSince combining the tags into a single request
?tags=system/type:fan,system/type:ledwould not work, as there is no device which would have both of those tags (cannot have two system-assigned types).With this PR, you can specify multiple tag groups from query params, so you can get back both all led and fan devices from a single request, e.g.
?tags=system/type:fan&tags=system/type:led