update sanic-prometheus to use full url label #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoceppi
approved these changes
Oct 22, 2019
lazypower
approved these changes
Oct 22, 2019
KylerBurke
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Without specifying
endpoint_type='url', the monitor defaults toendpoint_type='url:1'which signifies that it should only use the first element of the url. Since most of our endpoints are kept under the/v3root, this lead to the gathered metrics falling under only/testand/v3which isn't too helpful.This PR allows the full URL to be used. This will include URLs for specific resources (e.g.
/v3/read/1232358127462), so it may get messy with lots of requests, but that isn't terrible since it could help to identify devices which are slow to respond, etc.