Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: cannot get response size from body attr for streamed responses #344

Merged
merged 1 commit into from
Nov 7, 2019
Merged

bugfix: cannot get response size from body attr for streamed responses #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion synse_server/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,10 @@ async def before_response(request, response):

# We cannot use Content-Length header since that has not yet been
# calculated and added to the response headers.
if response.body is not None:
#
# Streaming responses do not have a 'body' attribute, so we cannot
# collect this data in those cases.
if hasattr(response, 'body') and response.body is not None:
self.http_resp_bytes.labels(*labels).inc(len(response.body))

@self.app.route('/metrics', methods=['GET'])
Expand Down