Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various bugfixes around tag processing #347

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • fixes a bug around user-specified namespaces for the tags request. in the event that only a single namespace is specified and not wrapped in a list, the tag processing would fail on namespace matching due to a string also being iterable (e.g. the algorithm iterated over the string characters instead of the expected strings in a list)
  • fixes a bug in the read command around how tags are passed along to the command handler. with the introduction of tag groups, the number of valid tag formats include:
    • a single string (a single tag)
    • a list of strings (one tag group, multiple tags)
    • a list of list of strings (multiple tag groups)
      the bug affected the second format, above, because the tags input was not normalized prior to processing, so the algorithm tried to iterate over a string instead of a list of string.
  • updated / added tests
  • bump to 3.0.0-alpha.13

Copy link
Contributor

@hoanhan101 hoanhan101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@edaniszewski edaniszewski merged commit 39fc0fc into v3/staging Nov 20, 2019
@edaniszewski edaniszewski deleted the v3/bugfixes branch November 20, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants