Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example dashboard - prometheus labels had changed #348

Merged
merged 2 commits into from
Dec 13, 2019

Conversation

edaniszewski
Copy link
Contributor

@edaniszewski edaniszewski commented Dec 13, 2019

This PR:

  • updates the example grafana dashboard for synse server application metrics. these were not updated when the exported metrics had changed.
  • adds additional labels to HTTP metrics to make them easier to aggregate

To run:

$ cd examples/monitoring
$ docker-compose up -d

then visit localhost:3000 in your web browser.

The example now has synse-loadgen attached, so if you let it run for a short while, you should see all the stuff populate.

Note due to the additional labels in this PR, you'll need to build this image locally (e.g. make docker) to have everything running happily. The emulator should also be the latest v3 release.

I think all of the charts make sense, but I'd like a second pair of eyes to make sure that the data is being displayed correctly (e.g. the queries do what the charts say they do)

@edaniszewski edaniszewski added the WIP Work In Progress label Dec 13, 2019
lazypower
lazypower previously approved these changes Dec 13, 2019
@edaniszewski edaniszewski removed the WIP Work In Progress label Dec 13, 2019
@edaniszewski
Copy link
Contributor Author

@lazypower @KylerBurke updated this to be more complete. its a bit of jumping hurdles to test it since you need the right versions of all the images, but if its not too much trouble, could either of you look through and make sure it looks ok and the queries make sense

Copy link
Contributor

@lazypower lazypower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fired up the dash and it looks pretty great.

The GRPC table is a nice touch. Nothing to add from me, good job 👍

@edaniszewski edaniszewski merged commit 5599351 into v3/staging Dec 13, 2019
@edaniszewski edaniszewski deleted the v3/monitoring-example branch December 13, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants