Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework logging for additional context and to include sanic logs #353

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • reworks a bit of the semantics of how synse does its logging in order to provide more context in log messages regarding log message source
  • adds in a bit of a nasty hack to get sanic logs output via structlog so they are included in the structure logging output
  • updates tests

This PR is intended to pave the way for additional logging work. Right now the synse server logs are okay at best, but they could use additional context to be more useful when debugging.

@edaniszewski edaniszewski merged commit 27a98a0 into v3/staging Jan 30, 2020
@edaniszewski edaniszewski deleted the v3/logging-rework branch January 30, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant