Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3/refresh on cache rebuild #361

Merged
merged 2 commits into from
Feb 5, 2020
Merged

V3/refresh on cache rebuild #361

merged 2 commits into from
Feb 5, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • adds a plugin manager util to check if all registered plugins are active
  • updates device cache rebuild to refresh plugins if not all are active. this fixes a bug where a plugin being restarted may not show up in a device scan despite being marked active, since it may be marked active after the cache rebuild ran

This should resolve #357

@edaniszewski edaniszewski linked an issue Feb 5, 2020 that may be closed by this pull request
investigate: plugins showing up as inactive upon redeploy #357
Closed
@edaniszewski edaniszewski merged commit 54b0329 into v3/staging Feb 5, 2020
@edaniszewski edaniszewski deleted the v3/refresh-on-cache-rebuild branch February 5, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoceppi marcoceppi marcoceppi approved these changes

@hoanhan101 hoanhan101 Awaiting requested review from hoanhan101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate: plugins showing up as inactive upon redeploy
2 participants
@edaniszewski @marcoceppi