bugfix: use a shared loop between sanic and asyncio components #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KylerBurke
approved these changes
Feb 20, 2020
| @@ -365,9 +401,8 @@ def log_request(request, **kwargs): | |||
| try: | |||
| async for reading in cmd.read_cache(start, end): | |||
| await response.write(ujson.dumps(reading) + '\n') | |||
| except Exception as e: | |||
| logger.error('failure when streaming cached readings') | |||
| logger.exception(e) | |||
MatthewHink
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
This is testing a ton better than previously. The thermistors blipped out for a bit, but they did re-appear. I think there is still an issue, but it's substantially better and we should take this PR.
Scan and synse logs:
|
^ It looks like i2c and snmp blipped out of the scan in this case. |
|
good to know! thanks for the logs. I'll merge this in but leave the associated issue open so we can keep exploring it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
I managed to reliably reproduce the issue seen in #362 locally before the fix, and was not able to reproduce after this fix.