New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix issues with txn cache ttl being set as well as rebuild clearing the cache #365

Merged

edaniszewski merged 1 commit into v3/staging from v3/txn-cache-bugfix

Feb 21, 2020

Contributor

edaniszewski commented Feb 21, 2020

This PR:

fixes a bug where the transaction cache ttl wasn't being correctly set because of an order of operations bug where config was not loaded in yet
fixes a bug where calling clear on any of the caches would clear the entire backing cache for all caches, regardless of namespace. this was causing transactions to be invalidated on device cache rebuild.

fixes #363


          bugfix: fix issues with txn cache ttl being set as well as rebuild cl…

342d349

…earing the cache

edaniszewski requested review from marcoceppi and MatthewHink

February 21, 2020 16:30

MatthewHink approved these changes

View reviewed changes

Contributor

MatthewHink left a comment

LGTM. Yeah that's strange to have an instance with a namespace and ignore it.

edaniszewski merged commit 4333868 into v3/staging

edaniszewski deleted the v3/txn-cache-bugfix branch

February 21, 2020 16:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet