Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to device cache rebuild and plugin refresh #366

Merged
merged 2 commits into from
Feb 21, 2020
Merged

updates to device cache rebuild and plugin refresh #366

merged 2 commits into from
Feb 21, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • reduces the amount of time the device cache lock is held during rebuild to make responses more timely when there is lock contention
  • prevents plugin refresh from running simultaneously

This work was geared toward improvements for #362 , but I don't believe either of these improvements necessarily impact it. Looking through the logs, I don't think these things are the cause of the blips in scan.

MatthewHink
MatthewHink approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@MatthewHink MatthewHink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense

@edaniszewski edaniszewski merged commit ee9db61 into v3/staging Feb 21, 2020
@edaniszewski edaniszewski deleted the v3/device-cache-rebuild branch February 21, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewHink MatthewHink MatthewHink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edaniszewski @MatthewHink