New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: remove i18n, as it is unused and implemented inconsistently #369

Merged

edaniszewski merged 1 commit into v3/staging from v3/remove-i18n

Feb 29, 2020

Contributor

edaniszewski commented Feb 29, 2020

This PR:

removes internationalization/localization from synse server. It was added a while ago probably prematurely. It is not well maintained and its use throughout the code base was incomplete/inconsistent. This feature has not been used since it was added, so it feels right to remove this layer of complexity for now. It should be straightforward to add back in if we ever need it, but until then, removing it reduces the overhead of maintaining it.


          update: remove i18n, as it is unused and implemented inconsistently

05e0add

marcoceppi approved these changes

View reviewed changes

edaniszewski merged commit 884c2ee into v3/staging

edaniszewski deleted the v3/remove-i18n branch

February 29, 2020 04:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment