Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics export for plugin monitoring, update dashboard #377

Merged
merged 1 commit into from
Mar 19, 2020
Merged

feat: add metrics export for plugin monitoring, update dashboard #377

merged 1 commit into from
Mar 19, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • adds exported metrics for various plugin data points (active/inactive/disabled...)
  • hooks those metrics up to the plugins/plugin manager
  • adds a section in the example dashboard to display those metrics (image below)

Screen Shot 2020-03-18 at 15 01 56

Shoutout to @KylerBurke with helping me with some of the prometheus queries (:

KylerBurke
KylerBurke approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@KylerBurke KylerBurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@edaniszewski edaniszewski merged commit 64ff6ed into v3/staging Mar 19, 2020
@edaniszewski edaniszewski deleted the v3/plugin-monitoring branch March 19, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoceppi marcoceppi marcoceppi approved these changes

@KylerBurke KylerBurke KylerBurke approved these changes

@lazypower lazypower Awaiting requested review from lazypower

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edaniszewski @marcoceppi @KylerBurke