Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug where plugin active state was not being set on timeout error for reads #380

Merged
merged 1 commit into from
Mar 20, 2020
Merged

fix bug where plugin active state was not being set on timeout error for reads #380

merged 1 commit into from
Mar 20, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • fixes a bug where plugin state was not being set to inactive if a read failed (timeout error). this was because the value returned by the client is a generator, but generator iteration happened outside the scope of the client context, which is where the plugin activity state gets set when the context is exited with an error.
  • adds a __repr__ definition to the Plugin class so logged collections of plugins are human readable
  • adds regression test for the bugfix

fixes #379

@edaniszewski edaniszewski linked an issue Mar 20, 2020 that may be closed by this pull request
plugin timeout error on read fails to update plugin state to inactive #379
Closed
@edaniszewski edaniszewski merged commit 757878f into v3/staging Mar 20, 2020
@edaniszewski edaniszewski deleted the v3/read-active-state-bug branch March 20, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoceppi marcoceppi marcoceppi approved these changes

@MatthewHink MatthewHink MatthewHink approved these changes

@lazypower lazypower Awaiting requested review from lazypower

@KylerBurke KylerBurke Awaiting requested review from KylerBurke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin timeout error on read fails to update plugin state to inactive
3 participants
@edaniszewski @marcoceppi @MatthewHink