feat: update plugin refresh to also update active/inactive state #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniszewski
requested review from
marcoceppi,
lazypower,
MatthewHink and
KylerBurke
marcoceppi
approved these changes
Mar 20, 2020
MatthewHink
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
/plugin?refresh=truemechanic to also update the active/inactive statePreviously, it did not do this intentionally, the idea being that the background task would be solely in charge of updating the active state. In practice, while debugging a different issue, I found that when doing a manual restart of plugins which could take a little time depending on what you are doing, this lead the exponential backoff to get to some high wait times, so even though the plugin was back online, Synse wasn't retrying its connection to it. Adding this manual means of kicking it to refresh active state means we can ensure plugin state is up to date.