Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: terminate server if invalid grpc cert is specified #391

Merged
merged 1 commit into from
Apr 13, 2020
Merged

bugfix: terminate server if invalid grpc cert is specified #391

merged 1 commit into from
Apr 13, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • adds a check to verify that the grpc cert exists, and fails if not
  • adds exception handling around grpc client creation, and propagates the exception up if client creation fails
  • adds regression tests

fixes #388

KylerBurke
KylerBurke approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@KylerBurke KylerBurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@edaniszewski edaniszewski merged commit e77bd60 into master Apr 13, 2020
@edaniszewski edaniszewski deleted the bugfix/invalid-grpc-cert branch April 13, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KylerBurke KylerBurke KylerBurke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server does not fail if invalid cert is specified for grpc transport
2 participants
@edaniszewski @KylerBurke