Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: catch any exceptions raised during server creation #392

Merged
merged 1 commit into from
Apr 13, 2020
Merged

bugfix: catch any exceptions raised during server creation #392

merged 1 commit into from
Apr 13, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • Fixes a bug where an exception raised during sanic server creation wasn't being retrieved from the task that the server creation was being performed in.

fixes #389

hoanhan101
hoanhan101 approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@hoanhan101 hoanhan101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@edaniszewski edaniszewski merged commit 4514810 into master Apr 13, 2020
@edaniszewski edaniszewski deleted the bugfix/bad-cert-terminate branch April 13, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoanhan101 hoanhan101 hoanhan101 approved these changes

@marcoceppi marcoceppi Awaiting requested review from marcoceppi

@KylerBurke KylerBurke Awaiting requested review from KylerBurke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid ssl configs do not cause plugin to terminate
2 participants
@edaniszewski @hoanhan101