Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --profile flag to enable simpler debug profiling #393

Merged
merged 1 commit into from
Apr 14, 2020
Merged

feat: add --profile flag to enable simpler debug profiling #393

merged 1 commit into from
Apr 14, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • adds a --profile flag to run synse with profiling enabled
  • updates Dockerfile so the workdir is well known (makes it easier to extract profiling data)
  • sets up signal listeners so synse server can be terminated gracefully

fixes #386

@edaniszewski edaniszewski mentioned this pull request Apr 14, 2020
Merged
hoanhan101
hoanhan101 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@hoanhan101 hoanhan101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@edaniszewski edaniszewski merged commit ad91f3a into master Apr 14, 2020
@edaniszewski edaniszewski deleted the profile-flag branch April 14, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoanhan101 hoanhan101 hoanhan101 approved these changes

@marcoceppi marcoceppi Awaiting requested review from marcoceppi

@KylerBurke KylerBurke Awaiting requested review from KylerBurke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a --profile flag to run synse with profiling enabled
2 participants
@edaniszewski @hoanhan101