Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix middleware logger to not get body length for streamed responses #397

Merged
merged 1 commit into from
Jun 24, 2020
Merged

bugfix: fix middleware logger to not get body length for streamed responses #397

merged 1 commit into from
Jun 24, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • fixes a bug where log context was referencing an attribute which did not exist for streamed http responses
  • adds regression tests

fixes #396

MatthewHink
MatthewHink approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@MatthewHink MatthewHink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me

@edaniszewski edaniszewski merged commit 06b96f2 into master Jun 24, 2020
@edaniszewski edaniszewski deleted the bugfix/streaming-response-middleware branch June 24, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazypower lazypower lazypower approved these changes

@MatthewHink MatthewHink MatthewHink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: request fails in metrics middleware handling of streamed response
3 participants
@edaniszewski @lazypower @MatthewHink