test + fixture cleanup, some bug fixes #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewHink
approved these changes
Feb 26, 2018
edaniszewski
pushed a commit
that referenced
this pull request
Apr 5, 2018
Some new paths to speed up builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Deadline: whenever
Summary
this PR does a lot of cleanup around tests. it consolidates fixtures which had duplicate definitions all over the place. it standardizes on a test data directory (~/_tmp_test) that is created and cleaned up during testing.
It also fixes a few bugs with some tests and a bug in the code where invalid transaction ids weren't handled correctly. Some of the reason this bug was missed before was because the 'fixture soup' we had made it seem like that case was covered, but it wasn't actually.
with all these changes, I found that unit and integration tests ran slightly faster on my machine. they are both already fast, so the difference doesn't really matter, but still nice all the same.
Related Issues