add healthcheck/readiness probe #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewHink
reviewed
Feb 27, 2018
| @@ -5,7 +5,7 @@ COPY ./requirements.txt requirements.txt | |||
|
|
|||
| RUN set -e -x \ | |||
| && apk --update --no-cache add \ | |||
| bash gcc \ | |||
| bash gcc curl \ | |||
There was a problem hiding this comment.
+100. FWIW I had seen some images don't even have vi on them. Cannot remember which ones.
There was a problem hiding this comment.
yeah - we may want to have development images vs. production images, e.g. dev images have additional tools (like vi) installed, production images have only the bare minimum needed to run.
MatthewHink
approved these changes
Feb 27, 2018
edaniszewski
pushed a commit
that referenced
this pull request
Apr 5, 2018
Test and dev make targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Deadline: --
Summary
Creates/updates the healthcheck/readiness probe for synse server. Updates README to add section on health checks.
Related Issues