fix bug causing integration tests to fail locally sometimes #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewHink
approved these changes
Mar 13, 2018
|
yup we should have the location and mode (unix/tcp) of each plugin logged out on plugin registration |
|
Thanks |
edaniszewski
pushed a commit
that referenced
this pull request
Apr 5, 2018
Increasing the graphql timeout to 5m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Deadline: --
Summary
the mock app used in integration tests was attempting to register plugins out of the default plugin directory, as expected if sockets exist there. the sockets that were there on my machine were placed there from local plugin testing/dev.
This change the default plugin dir to a temporary directory for testing so it shouldn't mess with anything local.
Related Issues