-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track Migrations Per Database #271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…query' closure results
gwynne
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A pile of minor nits but overall looks fine to me so far
…Migrator preview methods
gwynne
reviewed
May 12, 2020
…rationFactory closure
calebkleveter
changed the title
Run Migrations by Database ID
Track Migrations Per Database
May 14, 2020
tanner0101
requested changes
May 14, 2020
…ases.ids() method
…s this working before...?). Fix Migration reversion in FluentBenchmarker (migrations have to be reverted in reverse order). Fix batch numbers (you have to actually change the previous batch number if you expect it to, you know, change).
… working before without having the dependency at all, but why did it work for me locally in this broken form that definitely fails on Linux?
gwynne
added a commit
to stairtree/fluent-kit
that referenced
this pull request
May 16, 2020
tanner0101
approved these changes
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just needs release notes.
These changes are now available in 1.0.0-rc.1.27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrations are now tracked on the database they are run on, instead of all migrations being tracked on the default database. This resolves bugs that could occur when running the same migration on multiple databases.