Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse timestamp columns in text format. Fixes vapor/mysql-nio#71 #72

Merged
merged 6 commits into from
May 9, 2023

Conversation

samalone
Copy link
Contributor

@samalone samalone commented Feb 20, 2022

Add support for reading timestamp columns in text format.

Fixes #71

Signed-off-by: Stuart A. Malone <samalone@llamagraphics.com>
Signed-off-by: Stuart A. Malone <samalone@llamagraphics.com>
@0xTim 0xTim requested a review from gwynne February 21, 2022 13:18
Signed-off-by: Stuart A. Malone <samalone@llamagraphics.com>
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Merging #72 (2b73b5a) into main (12f282b) will increase coverage by 0.27%.
The diff coverage is 95.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   44.66%   44.94%   +0.27%     
==========================================
  Files          38       38              
  Lines        3253     3271      +18     
==========================================
+ Hits         1453     1470      +17     
- Misses       1800     1801       +1     
Impacted Files Coverage Δ
Sources/MySQLNIO/MySQLTime.swift 95.04% <92.30%> (-0.18%) ⬇️
Sources/MySQLNIO/MySQLData.swift 49.20% <100.00%> (+0.81%) ⬆️

@gwynne
Copy link
Member

gwynne commented May 9, 2023

The problem with the tests will be fixed by the merge of #95

@gwynne gwynne self-assigned this May 9, 2023
@gwynne gwynne added enhancement New feature or request semver-minor Contains new API labels May 9, 2023
@gwynne gwynne merged commit 4d2aa38 into vapor:main May 9, 2023
@VaporBot
Copy link

VaporBot commented May 9, 2023

These changes are now available in 1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-minor Contains new API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when reading MySQLTime formatted as text
4 participants