-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise in-memory database handling for modern SQLite #105
Conversation
…time, but since Fluent requires the ability to open multiple connections to the same database even when it's memory-only, emulate it by using temporary files on disk when a memory database is requested.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
===========================================
+ Coverage 68.37% 83.33% +14.95%
===========================================
Files 7 7
Lines 234 222 -12
===========================================
+ Hits 160 185 +25
+ Misses 74 37 -37
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
…er (no functional changes!)
… database filename.
… coverage (tests that actually exercise the appropriate code, not just for better coverage counts).
…instead of paths.
… some things depend on it even though they shouldn't.
These changes are now available in 4.4.0 |
SQLiteKit has for a long time depended on the use of SQLite's shared cache with in-memory databases to support opening multiple connections to such databases. However, SQLite has also for a long time specifically recommended the total omission of the shared cache, a recommendation which SQLiteNIO now follows as of vapor/sqlite-nio#51. Therefore, SQLiteKit now uses uniquely-named temporary files to emulate the feature when in-memory databases are requested.
Additional changes in this release: