Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BLOB column type #21

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Add support for BLOB column type #21

merged 1 commit into from
Aug 7, 2017

Conversation

samnung
Copy link
Contributor

@samnung samnung commented Jul 24, 2017

I've noticed that storing bytes into sqlite database creates string instead of blob. Well and the biggest problem is that it will create string that looks like this "[120, 220, ...]".
This pull request is fixing this problem. It will now store the BLOB data correctly.

Part of the code was taken from SQLite.swift library, see https://github.com/stephencelis/SQLite.swift/blob/38ece82483475784b2d2377671e5367427992a72/Sources/SQLite/Core/Statement.swift

@tanner0101 tanner0101 added this to the 2.1.0 milestone Aug 7, 2017
@tanner0101 tanner0101 added the enhancement New feature or request label Aug 7, 2017
@tanner0101 tanner0101 self-assigned this Aug 7, 2017
@tanner0101 tanner0101 merged commit f364a11 into vapor:master Aug 7, 2017
@tanner0101
Copy link
Member

Thanks!

tanner0101 added a commit that referenced this pull request Jun 7, 2018
Add support for BLOB column type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants