Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile when no Package.resolved is present #111

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix Dockerfile when no Package.resolved is present #111

merged 1 commit into from
Oct 18, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Oct 18, 2023

When no Package.resolved was present, the Dockerfile would generate an invalid command. This is now fixed.

Fixes #110.

@gwynne gwynne added the bug Something isn't working label Oct 18, 2023
@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy October 18, 2023 13:04
@gwynne gwynne enabled auto-merge (squash) October 18, 2023 13:11
@gwynne gwynne merged commit e589b2f into main Oct 18, 2023
11 checks passed
@gwynne gwynne deleted the gwynne-patch-1 branch October 18, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptoffy ptoffy ptoffy approved these changes

@dannflor dannflor dannflor approved these changes

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

@MahdiBM MahdiBM Awaiting requested review from MahdiBM

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerfile Failing to Build on First Try
3 participants
@gwynne @dannflor @ptoffy